[management] Update traffic events pagination filters #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds pagination filters to traffic events by introducing a new filter for "reporter_id" and updating search filter comments for clarity.
- Added a ReporterId filter to the API parameters.
- Updated search filter descriptions in both Go types and OpenAPI specification.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| management/server/http/api/types.gen.go | Added ReporterId filter and updated Search filter description. |
| management/server/http/api/openapi.yml | Added reporter_id query parameter and clarified Search filter description. |
Signed-off-by: bcmmbaga <[email protected]>
bcmmbaga
force-pushed
the
traffic-events-pagination-filters
branch
from
a8ee1b5 to
d809701
Compare
|
pascal-fischer
approved these changes
May 22, 2025
Gitroro73
reviewed
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist