[management] Extend nameserver match domain validation

[bcmmbaga]

Describe your changes

Issue ticket number and link

Closes #2021

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

[Copilot]

Pull Request Overview

This PR refactors domain validation to support single-label domains, top-level domains (prefixed with “.”), and wildcard domains, and updates tests accordingly.

• validateDomain now handles TLDs and *.-wildcards and removes the two-label minimum
• Introduced maxLabelLen, invalidDomainName, and a domainPattern regex (currently unused)
• Added new test cases for single-label, TLD, and wildcard domains in nameserver_test.go

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
management/server/nameserver.go	Extended validateDomain for TLDs & wildcards; added constants
management/server/nameserver_test.go	Added tests for single-label, .com, and *.example; renamed cases

Comments suppressed due to low confidence (4)

management/server/nameserver.go:6

• The regexp import is no longer used (the domainPattern regex isn’t referenced). Consider removing the import and the unused domainPattern constant to keep the code clean.

"regexp"

management/server/nameserver.go:23

• The domainPattern constant is defined but never used. Either integrate it into validateDomain or remove it to prevent confusion.

domainPattern = `^(?i)[\.*a-z0-9]+([\-\.]{1}[a-z0-9]+)*[*.a-z]{1,}$`

management/server/nameserver_test.go:921

• There’s no test case covering the behavior of a single-label domain without a dot or wildcard (e.g., "com"). Add a test to assert whether such domains should pass or fail.

// removed test for single-label "com"

management/server/nameserver.go:338

• The original check enforcing a minimum of two labels for non-TLD domains was removed, so single-label domains like "com" will now be accepted. Verify whether this change matches the intended validation rules.

if !valid {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This PR refactors domain validation logic and extends test coverage for various domain formats.

• Removed the minimum label count check and centralized the error return in validateDomain.
• Updated (but currently unused) domainPattern regex for domain matching.
• Expanded TestValidateDomain with new scenarios (single-label, trailing dot, wildcard, leading dot, dot-only).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
management/server/nameserver.go	Refactored validateDomain, added invalidDomainName var, updated domainPattern
management/server/nameserver_test.go	Extended and reordered test cases in TestValidateDomain

Comments suppressed due to low confidence (2)

management/server/nameserver.go:23

• [nitpick] Rename invalidDomainName to ErrInvalidDomainName to follow Go conventions for error variable names.

var invalidDomainName = errors.New("invalid domain name")

management/server/nameserver_test.go:908

• The test expects example. to pass, but dns.IsDomainName may reject trailing dots; verify the intention or adjust the test to match the actual validation behavior.

domain:  "example.",