Skip to content

[management] Reset test containers after cleanup #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

bcmmbaga
Copy link
Contributor

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 11:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the test utility for MySQL and Postgres containers by resetting their container variables after cleanup so they can be recreated in subsequent tests.

  • Added explicit nil assignments to mysqlContainer and pgContainer in their cleanup closures
  • Ensures containers don’t retain stale references after being terminated

Copy link

@bcmmbaga bcmmbaga merged commit a0d28f9 into main May 27, 2025
33 of 35 checks passed
@bcmmbaga bcmmbaga deleted the cleanup-test-containers branch May 27, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants