Skip to content

[server-test] Install libs for i386 tests #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

[server-test] Install libs for i386 tests #3887

merged 3 commits into from
May 27, 2025

Conversation

pappz
Copy link
Contributor

@pappz pappz commented May 27, 2025

Describe your changes

Install i386 dependencies to fix this:

In file included from _cgo_export.c:3:
/usr/include/stdlib.h:26:10: fatal error: bits/libc-header-start.h: No such file or directory
   26 | #include <bits/libc-header-start.h>

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 13:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a step in the GitHub Actions workflow to install dependencies required for running i386 tests.

  • Adds an "Install dependencies" step using apt to update the package list and install gcc-multilib, g++-multilib, and libc6-dev-i386
  • Executes the new step only when the cache is not hit

@@ -269,6 +269,11 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Install dependencies
Copy link
Preview

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment to explain the need for installing gcc-multilib, g++-multilib, and libc6-dev-i386 for i386 tests. This will improve the maintainability and clarity of the workflow.

Copilot uses AI. Check for mistakes.

@pappz pappz changed the title Install libs for i386 tests [server-test] Install libs for i386 tests May 27, 2025
Copy link

@pappz pappz merged commit 6f436e5 into main May 27, 2025
32 checks passed
@pappz pappz deleted the fix/i386-tests branch May 27, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants