[client] Fix HA router switch #3889
Merged
+57
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify the notification filter logic. Always send notification if a state has been changed - Remove IP changes check because we never modify
There was a problem hiding this comment.
Pull Request Overview
A bug fix for the HA router switch that simplifies the notification filter logic and removes unnecessary IP update checks.
- Removed redundant IP update logic in peer state update functions.
- Simplified the notification condition in shouldSkipNotify to only check for connection status changes.
client/internal/peer/status.go
Outdated
Comment on lines
506
to
509
| if receivedConnStatus == curr.ConnStatus { | ||
| return true | ||
| case receivedConnStatus == StatusIdle && curr.ConnStatus == StatusConnecting: | ||
| return true | ||
| case receivedConnStatus == StatusIdle && curr.ConnStatus == StatusIdle: | ||
| return curr.IP != "" | ||
| default: | ||
| return false | ||
| } | ||
| return false |
There was a problem hiding this comment.
[nitpick] Consider returning the boolean expression directly (i.e., 'return receivedConnStatus == curr.ConnStatus') to simplify the code.
Copilot uses AI. Check for mistakes.
…ed to disconnected. After implementing lazy connection, the peer state is connecting, so we did not decrease the reference counters on the routes.
|
mlsmaycon
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix HA router switch.
Describe your changes
Simplify the notification filter logic. Always send notification if a state has been changed
Remove IP changes check because we never modify
Issue ticket number and link
Stack
Checklist