[client] Refactor exclude list handling to use a map for permanent connections

[hakansa]

Describe your changes

[client] Refactor exclude list handling to use a map for permanent connections

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

Refactor the permanent connection exclusion logic to use a map for more efficient lookups.

• Update toExcludedLazyPeers to return a map[string]bool instead of a slice.
• Adjust SetExcludeList to accept a map[string]bool and iterate map keys.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
client/internal/engine.go	toExcludedLazyPeers now builds and returns a map of excluded peers
client/internal/conn_mgr.go	SetExcludeList signature updated to take a map and loop over keys

Comments suppressed due to low confidence (2)

client/internal/conn_mgr.go:100

• The comment still refers to a "list" but the method now accepts a map of peer IDs; update it to reflect the map-based parameter, e.g., "Sets the map of peer IDs..." or "Sets the set of peer IDs...".

// SetExcludeList sets the list of peer IDs that should always have permanent connections.

client/internal/engine.go:1930

• Consider adding or updating unit tests for toExcludedLazyPeers to ensure the map-based exclusion correctly handles duplicates, empty peers, and includes all intended entries.

func (e *Engine) toExcludedLazyPeers(routes []*route.Route, rules []firewallManager.ForwardRule, peers []*mgmProto.RemotePeerConfig) map[string]bool {