Skip to content

[management] Fix user groups propagation #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

bcmmbaga
Copy link
Contributor

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Signed-off-by: bcmmbaga <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 14:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a bug fix related to user groups propagation by updating the account identifier used when saving groups.

  • Changed the account identifier passed to SaveGroups from update.AccountID to accountID.
  • Ensures that the correct account context is used for group updates.
Comments suppressed due to low confidence (1)

management/server/user.go:679

  • Switching from update.AccountID to accountID appears intended to fix the propagation of user groups. Ensure that accountID correctly reflects the intended account context in all cases.
if err = transaction.SaveGroups(ctx, store.LockingStrengthUpdate, accountID, updatedGroups); err != nil {

Copy link

@bcmmbaga bcmmbaga merged commit 2bef214 into main May 30, 2025
53 of 56 checks passed
@bcmmbaga bcmmbaga deleted the fix/group-propagation branch May 30, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants