-
-
Notifications
You must be signed in to change notification settings - Fork 707
[client] Apply routes right away instead of on peer connection #3907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors routing logic by immediately applying routes instead of waiting on peer connection, while also renaming and reorganizing several internal types and functions for consistency. Key changes include:
- Updating dialog button labels in the UI for route-related error dialogs.
- Refactoring the server router and client watcher components with renamed types and methods.
- Adjusting DNS configuration updates and streamlining route updates in the engine.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
client/ui/debug.go | Updated dialog button labels from “Cancel” to “cancel”. |
client/internal/routemanager/static/route.go | Switched to inline error checking and added explicit return statements. |
client/internal/routemanager/server/server.go | Renamed internal router type from serverRouter to Router and updated method names. |
client/internal/routemanager/manager.go | Refactored client network watcher integration with new activeRoutes and update flow. |
client/internal/routemanager/client/client.go | Renamed and refactored client network (Watcher) functions and update handling. |
client/internal/engine.go | Moved and streamlined DNS server update logic. |
client/internal/dns/server.go | Modified debug logging to show extra domain keys using maps.Keys. |
Co-authored-by: hakansa <[email protected]>
Because the code generated new channel for every single event, was easy to miss notification. Use single channel.
|
Describe your changes
Issue ticket number and link
Stack
Checklist