[misc] Fail linter workflows on codespell failures #3913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the linter workflow configuration to fail on codespell errors and includes a minor documentation change.
- Updated the comment in dns/dns.go to mention an additional condition.
- Removed the "only_warn: 1" setting in the golangci-lint GitHub workflow to enforce failures on codespell errors.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dns/dns.go | Updated comment for DefaultClass |
| .github/workflows/golangci-lint.yml | Removed only_warn flag to fail on codespell errors |
dns/dns.go
Outdated
| @@ -17,7 +17,7 @@ const ( | |||
| DefaultDNSPort = 53 | |||
| // RootZone is a string representation of the root zone | |||
| RootZone = "." | |||
| // DefaultClass is the class supported by the system | |||
| // DefaultClass is the class supported by the system or by wether | |||
There was a problem hiding this comment.
There appears to be a typo in the comment: 'wether' should likely be 'whether' for clarity.
Suggested change
| // DefaultClass is the class supported by the system or by wether | |
| // DefaultClass is the class supported by the system or by whether |
Copilot uses AI. Check for mistakes.
|
crn4
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist