-
-
Notifications
You must be signed in to change notification settings - Fork 707
[client] Add systemd netbird logs to debug bundle #3917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the debug bundle by adding support for collecting systemd journal logs. Key changes include:
- Adding trySystemdLogFallback functions for both Linux and non-Linux environments.
- Implementing detailed journal log collection in the Linux debug file with service name resolution and log anonymization.
- Updating the archive creation logic to conditionally add log files or fallback systemd logs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
client/internal/debug/debug_nonlinux.go | Added stub function for systemd log fallback on non-Linux systems |
client/internal/debug/debug_linux.go | Introduced robust systemd journal log collection with timeout, error handling, and anonymization |
client/internal/debug/debug.go | Updated log file condition to optionally trigger systemd log fallback |
|
Describe your changes
Issue ticket number and link
Stack
Checklist