Skip to content

remove error causing dnf config-manager add #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

orchard0
Copy link
Contributor

@orchard0 orchard0 commented Jun 4, 2025

Describe your changes

This PR fixes the issue #3014.

dnf config-manager is useful for adding a remote repo file but the add_rpm_repo function called on line 264 already writes the repo to the appropriate location and therefore when dnf config-manager is ran it raises an error stating that the repo already exists. This causes the script to stop and prevents the installation from completing. Users have found adding --overwrite to dnf config-manager works (#3014 (comment)) but this is unnecessary to begin with.

Issue ticket number and link

#3014.

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

sonarqubecloud bot commented Jun 4, 2025

@mlsmaycon mlsmaycon merged commit 122a89c into netbirdio:main Jun 5, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants