Skip to content

[client] Run registerdns before flushing #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2025
Merged

[client] Run registerdns before flushing #3926

merged 3 commits into from
Jun 5, 2025

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Jun 4, 2025 •
edited
Loading

Describe your changes

  • run ipconfig /registerdns before flushing
  • disable WINS on the netbird interface
  • disable "dynamic updates" and "registration enabled" on the interface

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 17:14
Copilot
Copilot AI reviewed Jun 4, 2025
View reviewed changes
hakansa
hakansa previously approved these changes Jun 5, 2025
View reviewed changes
@lixmal lixmal force-pushed the registerdns-windows branch from 952570d to 233c024 Compare June 5, 2025 09:11
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lixmal lixmal merged commit 55957a1 into main Jun 5, 2025
32 checks passed
@lixmal lixmal deleted the registerdns-windows branch June 5, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@hakansa hakansa hakansa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lixmal @hakansa