Skip to content

[client] Increase stun status probe timeout #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Jun 5, 2025

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@Copilot Copilot AI review requested due to automatic review settings June 5, 2025 12:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the stun status probe by increasing the timeout and correcting the probe type used for TURN URIs.

  • Increase the timeout in the relay probe from 2 to 6 seconds.
  • Change the probe function for TURN URIs from ProbeSTUN to ProbeTURN.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
client/internal/relay/relay.go Increased probe timeout to 6 seconds
client/internal/engine.go Corrected probe type: now using ProbeTURN for TURN URIs
Comments suppressed due to low confidence (1)

client/internal/engine.go:1681

  • The change from using ProbeSTUN to ProbeTURN for TURN URIs appears correct; please verify that the ProbeTURN function properly handles TURN-specific logic.
relay.ProbeAll(e.ctx, relay.ProbeTURN, turns)...,

Copy link

sonarqubecloud bot commented Jun 5, 2025

@lixmal lixmal merged commit 64f1119 into main Jun 5, 2025
33 of 36 checks passed
@lixmal lixmal deleted the improve-stun-status-timeout branch June 5, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants