Skip to content
This repository was archived by the owner on Aug 10, 2020. It is now read-only.

Update telemetry validation #5

Merged
merged 1 commit into from
Mar 29, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/utils/telemetry/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,12 @@ function track(eventName, payload) {
if (eventName.indexOf('cli:') === -1) {
eventName = `cli:${eventName}`
}


const allowed = () => true
// event 'cli:command' bypasses validation
const isValid = (eventName === 'cli:command') ? allowed : isValidEventName
// to ensure clean data, validate event name
if (!isValidEventName(eventName, eventConfig)) {
if (!isValid(eventName, eventConfig)) {
return false
}

Expand Down