Skip to content

fix: ESM-specific configuration bugs #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2022
Merged

fix: ESM-specific configuration bugs #445

merged 1 commit into from
Feb 3, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Feb 2, 2022

We have just added an ESM-specific configuration file.

I tried to use the new exports feature which allows the import name to be different from the file path being imported. However, this seems to fail with ESLint and report a "module not found" error. When making the import name mirror the imported file path, this error disappears.

Also, when merging the base ESLint configuration, I forgot to merge its parserOptions.

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Feb 2, 2022
@ehmicky ehmicky self-assigned this Feb 2, 2022
@ehmicky ehmicky merged commit d37f52d into main Feb 3, 2022
@ehmicky ehmicky deleted the chore/fix-esm-2 branch February 3, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants