Skip to content
This repository was archived by the owner on Sep 12, 2019. It is now read-only.

Output improvements #63

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Output improvements #63

merged 4 commits into from
Apr 2, 2019

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Apr 1, 2019

  1. Preserve original output from subprocess.
    This will keep the format and color from the subprocess, although we cannot
    modify mentions to local urls by doing this.

  2. Add a banner advertising the final server URL.
    So it's not as hard to miss across all the log.

  3. Unify subprocess handling to execa.
    So it's platform compatible.

Fixes #57
Fixes #45
Fixes #63

@calavera calavera requested review from swyxio and biilmann April 1, 2019 20:53
@calavera
Copy link
Contributor Author

calavera commented Apr 1, 2019

It looks like this:

Screenshot from 2019-04-01 13-54-34

sw-yx and others added 4 commits April 2, 2019 01:04
@swyxio swyxio force-pushed the preserve_output branch from ec62ab9 to a82dda7 Compare April 2, 2019 05:06
@swyxio
Copy link
Contributor

swyxio commented Apr 2, 2019

LGTM. i only rebased.

@swyxio swyxio merged commit 631c197 into master Apr 2, 2019
@swyxio swyxio deleted the preserve_output branch April 2, 2019 05:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants