Skip to content
This repository was archived by the owner on Sep 12, 2019. It is now read-only.

Make addon install lifecycle #74

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Make addon install lifecycle #74

merged 2 commits into from
Apr 4, 2019

Conversation

swyxio
Copy link
Contributor

@swyxio swyxio commented Apr 3, 2019

  • no need to run netlify dev:exec after running a template that requires a postinstall step, just specify it in a template.

see fauna template for example.

code notes:

  • refactored addEnvVarsFromAddons to make reusable for both dev:exec and functions:create

@swyxio
Copy link
Contributor Author

swyxio commented Apr 3, 2019

demo of this: about 1min after this video ended the db started working. this confirms @mathias’ suspicion that there needs to be some warmup time for the db instance to work https://www.youtube.com/watch?v=UGYJCzBJzl8

@swyxio swyxio merged commit 11eb304 into master Apr 4, 2019
@swyxio swyxio deleted the makeAddonInstallLifecycle branch April 4, 2019 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant