Better error messages #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarsaTM
force-pushed
the
gremlin-error-messages
branch
from
1f18e16 to
b8ada3b
Compare
BarsaTM
force-pushed
the
gremlin-error-messages
branch
from
9462927 to
8b1280d
Compare
- Added tests for ExceptionWrapper - Added tracktrace information - Fixed possble memory leak - Added resizable property to the popup - Refactoring
BarsaTM
force-pushed
the
gremlin-error-messages
branch
2 times, most recently
from
99618fe to
3fa9902
Compare
- Moved `wrap exception in meaning message` logic closer to OpenCypherGremlinDatabase impl. - Cleaned places where wrapping exception is not necessary - Rebase - Misc.
BarsaTM
force-pushed
the
gremlin-error-messages
branch
from
3fa9902 to
71b303e
Compare
dwitry
suggested changes
Oct 8, 2019
...ins/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/console/log/LogPanel.java
Outdated
Show resolved
Hide resolved
...ins/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/console/log/LogPanel.java
Outdated
Show resolved
Hide resolved
...neueda/jetbrains/plugin/graphdb/database/opencypher/gremlin/exceptions/ExceptionWrapper.java
Outdated
Show resolved
Hide resolved
ex3m1024
reviewed
Oct 8, 2019
...neueda/jetbrains/plugin/graphdb/database/opencypher/gremlin/exceptions/ExceptionWrapper.java
Outdated
Show resolved
Hide resolved
BarsaTM
force-pushed
the
gremlin-error-messages
branch
3 times, most recently
from
a85ddea to
c609b5c
Compare
BarsaTM
force-pushed
the
gremlin-error-messages
branch
from
c609b5c to
96b1da6
Compare
ex3m1024
approved these changes
Oct 8, 2019
|
To be fair, the current height of the exception dialog is too small to allow reading the stacktrace conveniently. May I suggest we tweak it a little bit (at least make the text window resizable, better yet - fill the whole window, leaving some fixed space for the ellipsed error message) |
dwitry
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.