Added inspection to show warnings from explain queries #18
Conversation
| @Override | ||
| public void setUp() throws Exception { | ||
| super.setUp(); | ||
| this.dsApi = dataSource().neo4j31(); |
There was a problem hiding this comment.
Do we need to include neo4j30() data source in tests? Some of my tests are doing multi-neo4j-version tests.
This is not a requirement, more like general question.
There was a problem hiding this comment.
Well, dataSource here is used just to get an instance of data source api, so we could easily generate file name for data source specific cypher file.
We could remove it, but then the file name generation would be done somewhere else.
There was a problem hiding this comment.
You are wrong. Data source is used not only for generation, but also for Query execution. You need to get actual notification somewhere :)
There was a problem hiding this comment.
yep, true. Completely forgot about that, while was writing comment :)
| import com.neueda.jetbrains.plugin.graphdb.jetbrains.util.NameUtil; | ||
| import com.neueda.jetbrains.plugin.graphdb.test.integration.neo4j.util.base.BaseIntegrationTest; | ||
|
|
||
| public class CypherExplainWarningInspectionTest extends BaseIntegrationTest { |
There was a problem hiding this comment.
We are go going to add more inspections in future. Let's extract some of the logic in "BaseInspectionTest"
Logic to extract:
- Inspection class to enable
- Configure from existing existing file + check highligting
- Create data source file + add file to project
| myFixture.configureFromExistingVirtualFile(psiFile.getVirtualFile()); | ||
| myFixture.checkHighlighting(); | ||
| } | ||
|
|
There was a problem hiding this comment.
There should be test that check behaviour if we are in data source bound file, but there are no actual data source,
| if (fileName.startsWith(GraphConstants.BOUND_DATA_SOURCE_PREFIX)) { | ||
| DataSourcesComponent component = statement.getProject().getComponent(DataSourcesComponent.class); | ||
|
|
||
| component.getDataSourceContainer() |
| return null; | ||
| } | ||
| } | ||
|
|
|
|
||
| @Nullable | ||
| @Override | ||
| public String loadDescription() { |
There was a problem hiding this comment.
remove this accidentally added code
Metaur
force-pushed
the
explaining_inspection
branch
from
b1a040d to
31b1e30
Compare
No description provided.