Dynamically created tabs are shown on explain and profile queries #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metaur
force-pushed
the
query-plan-tree-table
branch
from
f00bc64 to
528da71
Compare
FylmTM
suggested changes
Jan 17, 2017
| @@ -119,6 +146,38 @@ private void createUIComponents() { | |||
| graphCanvas = new JPanel(new GridLayout(0, 1)); | |||
| consoleTabsPane = new JBTabsPaneImpl(null, SwingConstants.TOP, this); | |||
| consoleTabs = (JBTabsImpl) consoleTabsPane.getTabs(); | |||
|
|
|||
| consoleTabs.addTabMouseListener(new MouseListener() { | |||
There was a problem hiding this comment.
There should be MouseAdaptor somewhere, that can be used to override only necessary methods.
| final TabInfo info = consoleTabs.findInfo(e); | ||
| if (info != null) { | ||
| String tabTitle = info.getText(); | ||
| if (tabTitle.startsWith("Profile") || tabTitle.startsWith("Explain")) { |
There was a problem hiding this comment.
If we are making comparisons using strings, then we should put them in constants and reuse constants
| }); | ||
| tabInfo.setTabLabelActions(tabActions, ActionPlaces.EDITOR_TAB); | ||
|
|
||
| String planType = result.hasProfile() ? "Profile" : "Explain"; |
|
|
||
| boolean hasProfile(); | ||
|
|
||
| GraphQueryPlan getPlan(); |
There was a problem hiding this comment.
As I understand "hasPlan()" is main method. And it is accompanied with "getPlan()"
In this case "hasProfile" is misleading. I would prefer it be called "isProfilePlan()" to clearly define that it actually specifies type of plan.
| .orElse(false); | ||
| } | ||
|
|
||
| public GraphQueryPlan getQueryPlan() { |
There was a problem hiding this comment.
I think we want to use Optional here.
Metaur
force-pushed
the
query-plan-tree-table
branch
from
f2f3075 to
8359c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.