Skip to content

apply variables refactoring in given statement only #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
import com.intellij.openapi.util.TextRange;
import com.intellij.psi.PsiElement;
import com.intellij.psi.ResolveResult;
import com.neueda.jetbrains.plugin.graphdb.language.cypher.psi.CypherStatement;
import com.neueda.jetbrains.plugin.graphdb.language.cypher.psi.CypherTypes;
import com.neueda.jetbrains.plugin.graphdb.language.cypher.references.CypherReferenceBase;
import com.neueda.jetbrains.plugin.graphdb.language.cypher.util.CypherUtil;
import com.neueda.jetbrains.plugin.graphdb.language.cypher.util.PsiTraversalUtilities;
import com.neueda.jetbrains.plugin.graphdb.platform.GraphIcons;
import org.jetbrains.annotations.NotNull;

Expand All @@ -24,7 +26,8 @@ public CypherVariableReference(@NotNull PsiElement element, TextRange textRange)
@NotNull
@Override
public ResolveResult[] multiResolve(boolean incompleteCode) {
return resolveResults(CypherUtil.findAllByName(myElement.getContainingFile(), CypherTypes.VARIABLE, name));
PsiElement statementElement = PsiTraversalUtilities.getParentOfType(myElement, CypherStatement.class);
return resolveResults(CypherUtil.findAllByName(statementElement, CypherTypes.VARIABLE, name));
}

@NotNull
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.intellij.openapi.project.Project;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
import com.intellij.psi.PsiManager;
import com.intellij.psi.search.FileTypeIndex;
Expand Down Expand Up @@ -42,6 +43,10 @@ public static <T extends CypherNamedElement> List<T> findAllByName(PsiFile file,
return findAllAndFilter(file, elementType, (element) -> name.equals(element.getName()));
}

public static <T extends CypherNamedElement> List<T> findAllByName(PsiElement psiElement, IElementType elementType, String name) {
return findAllAndFilter(psiElement, elementType, (element) -> name.equals(element.getName()));
}

public static <T extends CypherNamedElement> List<T> findAllAndFilter(Project project, IElementType elementType, Filter filter) {
Collection<VirtualFile> virtualFiles = FileBasedIndex.getInstance()
.getContainingFiles(FileTypeIndex.NAME, CypherFileType.INSTANCE, GlobalSearchScope.allScope(project));
Expand All @@ -59,9 +64,21 @@ public static <T extends CypherNamedElement> List<T> findAllAndFilter(Project pr
}

public static <T extends CypherNamedElement> List<T> findAllAndFilter(PsiFile file, IElementType elementType, Filter filter) {
List<T> sameElements = null;
List<T> candidates = TraverseUtil.collectPsiElementsByType(file, elementType);
return filterSameElementsFromCandidates(candidates, filter);
}

public static <T extends CypherNamedElement> List<T> findAllAndFilter(PsiElement psiElement, IElementType elementType, Filter filter) {
List<T> candidates = TraverseUtil.collectPsiElementsByType(psiElement, elementType);
return filterSameElementsFromCandidates(candidates, filter);
}

public interface Filter {
boolean filter(CypherNamedElement element);
}

private static <T extends CypherNamedElement> List<T> filterSameElementsFromCandidates(List<T> candidates, Filter filter) {
List<T> sameElements = null;
for (T candidate : candidates) {
if (filter.filter(candidate)) {
if (sameElements == null) {
Expand All @@ -72,10 +89,5 @@ public static <T extends CypherNamedElement> List<T> findAllAndFilter(PsiFile fi
}

return sameElements != null ? sameElements : Collections.emptyList();

}

public interface Filter {
boolean filter(CypherNamedElement element);
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.neueda.jetbrains.plugin.graphdb.jetbrains.psi;
package com.neueda.jetbrains.plugin.graphdb.language.cypher.util;

import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
MATCH (renamed)
RETURN (renamed);
MATCH (renameThis)
RETURN (renameThis);

MATCH (renamed)
RETURN (renamed);
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import com.neueda.jetbrains.plugin.graphdb.jetbrains.component.analytics.Analytics;
import com.neueda.jetbrains.plugin.graphdb.jetbrains.component.datasource.DataSourcesComponent;
import com.neueda.jetbrains.plugin.graphdb.jetbrains.component.datasource.state.DataSourceApi;
import com.neueda.jetbrains.plugin.graphdb.jetbrains.psi.PsiTraversalUtilities;
import com.neueda.jetbrains.plugin.graphdb.language.cypher.util.PsiTraversalUtilities;
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.console.ConsoleToolWindow;
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.console.event.QueryParametersRetrievalErrorEvent;
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.console.params.ParametersService;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
import com.intellij.ui.Colors;
import com.neueda.jetbrains.plugin.graphdb.jetbrains.psi.PsiTraversalUtilities;
import com.neueda.jetbrains.plugin.graphdb.language.cypher.util.PsiTraversalUtilities;
import com.neueda.jetbrains.plugin.graphdb.platform.GraphLanguages;

public class SyncedElementHighlighter {
Expand Down