Simple cypher formatter #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metaur
force-pushed
the
simple-cypher-formatting
branch
from
c8659a6 to
fd18892
Compare
Metaur
force-pushed
the
simple-cypher-formatting
branch
from
3a42a35 to
01d6b90
Compare
Metaur
force-pushed
the
simple-cypher-formatting
branch
from
d9eba1a to
e50375d
Compare
FylmTM
reviewed
Feb 14, 2017
config/checkstyle/suppression.xml
Outdated
| <suppress files="DataSourceV\d+.java" checks="VisibilityModifier"/> | ||
| <suppress files="DataSourcesComponentState.java" checks="VisibilityModifier"/> | ||
| <suppress files="DataSourceContainerV\d+.java" checks="VisibilityModifier"/> | ||
| <suppress files="[\w_]+Test.java" checks="[a-zA-Z0-9]*"/> | ||
| <suppress files="CypherCodeStyleSettings.java" checks="MemberName"/> |
|
|
||
| private boolean isNonStarCount(@NotNull ASTNode node) { | ||
| IElementType type = node.getElementType(); | ||
| return type == CypherTypes.K_COUNT && TreeUtil.findParent(node, CypherTypes.COUNT_STAR) == null; |
| private boolean isLookupFunction(@NotNull ASTNode node) { | ||
| IElementType type = node.getElementType(); | ||
| return (type == CypherTypes.K_NODE || type == CypherTypes.K_REL || type == CypherTypes.K_RELATIONSHIP) | ||
| && TreeUtil.findParent(node, CypherTypes.LOOKUP) != null; |
| && TreeUtil.findChildBackward(element.getNode(), CypherTypes.K_COUNT) == null) { | ||
| String text = element.getText(); | ||
| char first = text.charAt(0); | ||
| return Character.toLowerCase(first) + text.substring(1); |
There was a problem hiding this comment.
check 1-char length function names
| int singleCount = CharMatcher.is('\'').countIn(text); | ||
| int doubleCount = CharMatcher.is('"').countIn(text); | ||
|
|
||
| text = text.replace("\\", ""); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is