filter required parameters for query execution #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalecka
force-pushed
the
filter-query-params
branch
from
df9f9b5 to
72bb53b
Compare
gdalecka
force-pushed
the
filter-query-params
branch
from
72bb53b to
d7a1dd7
Compare
gdalecka
commented
Jan 24, 2017
| throw new IllegalStateException("Old parameter should have symbolic name or unsigned decimal integer value"); | ||
| } | ||
|
|
||
| throw new IllegalStateException("Parameter should have either new parameter or old parameter representation"); |
There was a problem hiding this comment.
return "graphbdb-plugin-invalid-parameter-name-should-never-happen";
gdalecka
commented
Jan 24, 2017
| Map<String, Object> result = parametersService | ||
| .getParameters(getPsiFile("match (p:Person) where p.name = $name return *")); | ||
|
|
||
| assertThat(result.keySet()).contains("name"); |
There was a problem hiding this comment.
assertThat(result).containsChtoTo("name", "Anna")
gdalecka
commented
Jan 24, 2017
|
|
||
| Map<String, Object> jsonVal = (Map<String, Object>) result.get("p3"); | ||
| assertThat(jsonVal).containsKey("name"); | ||
| assertThat(jsonVal).containsValue("Alex"); |
There was a problem hiding this comment.
assertThat(jsonVal).hasSize()
gdalecka
commented
Jan 24, 2017
| throw new IllegalStateException("Parameters provider already registered"); | ||
| } | ||
| this.parametersProvider = parametersProvider; | ||
| } | ||
|
|
||
| public Map<String, Object> getParameters() throws Exception { | ||
| public Map<String, Object> getParameters(PsiElement query) throws Exception { |
gdalecka
commented
Jan 24, 2017
| private Set<String> extractParameterNames(PsiElement query) { | ||
| List<PsiElement> parameterElements = TraverseUtil.collectPsiElementsByType(query, CypherTypes.PARAMETER); | ||
| return parameterElements.stream() | ||
| .map(elem -> CypherPsiImplUtil.getParameterName(((CypherParameter) elem))) |
There was a problem hiding this comment.
((CypherParameter) elem).getParameterName()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.