Skip to content

File context menu #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2017
Merged

File context menu #43

merged 3 commits into from
Feb 16, 2017

Conversation

Vorago
Copy link
Contributor

@Vorago Vorago commented Feb 16, 2017

This change is Reviewable

@FylmTM
Copy link
Contributor

FylmTM commented Feb 16, 2017

Review status: 0 of 11 files reviewed at latest revision, 4 unresolved discussions.


database/neo4j/src/main/java/com/neueda/jetbrains/plugin/graphdb/database/neo4j/bolt/Neo4jBoltDatabase.java, line 78 at r1 (raw file):

            long startTime = System.currentTimeMillis();
            StatementResult statementResult = null;

Should consume result


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/ExecuteAllAction.java, line 51 at r1 (raw file):

ues("Andrew");
else {
Notification.error()
}


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/StatementCollector.java, line 67 at r1 (raw file):

//TODO fixme. Avoid DoS'ing messageBus
Maybe delete?


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/database/QueryExecutionService.java, line 71 at r1 (raw file):

String query = payload.getQueries().get(0);
Put a if for 1 element


Comments from Reviewable

@FylmTM
Copy link
Contributor

FylmTM commented Feb 16, 2017

Reviewed 7 of 11 files at r1, 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.


Comments from Reviewable

@FylmTM
Copy link
Contributor

FylmTM commented Feb 16, 2017

:lgtm:


Review status: all files reviewed at latest revision, 4 unresolved discussions.


Comments from Reviewable

@FylmTM
Copy link
Contributor

FylmTM commented Feb 16, 2017

Review status: all files reviewed at latest revision, 4 unresolved discussions.


database/neo4j/src/main/java/com/neueda/jetbrains/plugin/graphdb/database/neo4j/bolt/Neo4jBoltDatabase.java, line 78 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…

Should consume result

ok


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/ExecuteAllAction.java, line 51 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…

ues("Andrew");
else {
Notification.error()
}

ok


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/StatementCollector.java, line 67 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…

//TODO fixme. Avoid DoS'ing messageBus
Maybe delete?

ok


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/database/QueryExecutionService.java, line 71 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…

String query = payload.getQueries().get(0);
Put a if for 1 element

ok


Comments from Reviewable

@FylmTM FylmTM merged commit efdec80 into master Feb 16, 2017
@FylmTM FylmTM deleted the file-context-menu branch February 16, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants