feat(providers): Add Epic Games provider #12944
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@yaelbrinkert is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ThangHuuVu
requested changes
May 10, 2025
| authorization: { | ||
| url: "https://www.epicgames.com/id/authorize", | ||
| params: { | ||
| scope: "profile friends_list country", |
There was a problem hiding this comment.
for default scope, let's not include these
Suggested change
| scope: "profile friends_list country", | |
| scope: "profile", |
|
|
||
| token: { | ||
| url: "https://api.epicgames.dev/epic/oauth/v2/token", | ||
| async request(context) { |
There was a problem hiding this comment.
we can simplify this by utilising the property token_endpoint_auth_method: 'client_secret_basic'
no need to specify the fetch call manually here.
Comment on lines
139
to
140
| clientId: options.clientId, | ||
| clientSecret: options.clientSecret, |
There was a problem hiding this comment.
no needed to be explicit define these
|
Hi, i have to ask, should i update my fork and make another PR (with your
modifications of course) on the new release 5.0.0-beta ? Or i should stay
with the fork i've created 2 months ago ?
Thank you for all your precisions.
Yael
Le sam. 10 mai 2025 à 05:15, Thang Vu ***@***.***> a écrit :
… ***@***.**** requested changes on this pull request.
Thanks, I have dropped some comments
btw, could you also update this file: docs/pages/data/manifest.json with
the provider name
And could you also record a video showing that it is working on your end?
------------------------------
In packages/core/src/providers/epicgames.ts
<#12944 (comment)>
:
> + * clientSecret: process.env.EPIC_CLIENT_SECRET,
+ * })
+ * ]
+ * ```
+ */
+export default function EpicGamesProvider<P extends EpicGamesProfile>(
+ options: OAuthUserConfig<P>
+): OAuthConfig<P> {
+ return {
+ id: "epicgames",
+ name: "Epic Games",
+ type: "oauth",
+ authorization: {
+ url: "https://www.epicgames.com/id/authorize",
+ params: {
+ scope: "profile friends_list country",
for default scope, let's not include these
⬇️ Suggested change
- scope: "profile friends_list country",
+ scope: "profile",
------------------------------
In packages/core/src/providers/epicgames.ts
<#12944 (comment)>
:
> +): OAuthConfig<P> {
+ return {
+ id: "epicgames",
+ name: "Epic Games",
+ type: "oauth",
+ authorization: {
+ url: "https://www.epicgames.com/id/authorize",
+ params: {
+ scope: "profile friends_list country",
+ response_type: "code",
+ },
+ },
+
+ token: {
+ url: "https://api.epicgames.dev/epic/oauth/v2/token",
+ async request(context) {
we can simplify this by utilising the property token_endpoint_auth_method:
'client_secret_basic'
no need to specify the fetch call manually here.
------------------------------
In packages/core/src/providers/epicgames.ts
<#12944 (comment)>
:
> + clientId: options.clientId,
+ clientSecret: options.clientSecret,
no needed to be explicit define these
—
Reply to this email directly, view it on GitHub
<#12944 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASAI36OWGFG6JIDKPOPVBV325VVNZAVCNFSM6AAAAAB4W423WCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZQGEYTQNBTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
github-actions
bot
added
adapters
github-actions
bot
added
frameworks
solidjs
examples
svelte
drizzle
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
📌 Resources