Add server info #128
Closed
Add server info #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the info and version commands to get various info about the docker server. My use-case for this is forwarding a lot of information to logstash from various clusters and wanting to be able to track down the server that the log entry is coming from quickly. Since fleet can deploy containers to different servers based on rules and availability, getting the hostname that the container lives on is vital.
|
This LGTM. This diff is easier to review: https://github.com/jwilder/docker-gen/pull/128/files?w=1 One question I have is why the check for |
|
Only because it's nested inside. I could split them out into two different structs next to each other if you think it makes more sense. I was trying to not make the root struct too messy. |
|
Sounds good. Let's see what @jwilder thinks.
|
| Volumes map[string]Volume | ||
| Node SwarmNode | ||
| Labels map[string]string | ||
| Server ServerInfo |
There was a problem hiding this comment.
Maybe name this Docker instead? Server is kind of nebulous.
|
Fixed via #146. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the info and version commands to get various info about the docker server.
My use-case for this is forwarding a lot of information to logstash from various clusters and wanting to be able to track down the server that the log entry is coming from quickly. Since fleet can deploy containers to different servers based on rules and availability, getting the hostname that the container lives on is vital.
I've also updated the structs in the README to match what's currently in the code.
Let me know if you have any questions/changes/etc.
Thanks!
Ted