Skip to content

Added whereExist and whereNotExist #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2015
Merged

Conversation

ejhayes
Copy link

@ejhayes ejhayes commented Feb 23, 2015

This includes template helpers whereExist and whereNotExist. I found myself looking for containers that did not have an environment variable and wanted an easy way to query containers (existing where function didn't seem to work with "" or nil).

@thaJeztah
Copy link
Contributor

I think there's an error in the Dockerfile, because it now refers to your repository, not the "main" repository.

(Perhaps the Dockerfile changes should not be part of the pull-request)

@ejhayes
Copy link
Author

ejhayes commented Feb 23, 2015

Alright removed - thanks for pointing that out @thaJeztah

@thaJeztah
Copy link
Contributor

Hehe, no sweat, easy mistake to make, I just spotted it :)

jwilder added a commit that referenced this pull request Feb 23, 2015
Added whereExist and whereNotExist
@jwilder jwilder merged commit 0a392f5 into nginx-proxy:master Feb 23, 2015
@jwilder
Copy link
Collaborator

jwilder commented Feb 23, 2015

Thanks!

@ejhayes
Copy link
Author

ejhayes commented Feb 23, 2015

Thanks @jwilder - want to add this to 0.3.7 or 0.3.8?

@md5
Copy link
Contributor

md5 commented Feb 23, 2015

@ejhayes I just thought I'd point out that Git tags should generally not be changed after they're created, so the thing to do would be to cut a new version.

@ejhayes
Copy link
Author

ejhayes commented Feb 23, 2015

@md5 totally makes sense. This should be in 0.3.8 in then :)

@md5
Copy link
Contributor

md5 commented Feb 23, 2015

🤘

@jwilder
Copy link
Collaborator

jwilder commented Feb 23, 2015

Yeah... will go in 0.3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants