Skip to content

Always expose container address #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2015

Conversation

md5
Copy link
Contributor

@md5 md5 commented May 12, 2015

Previously, it was not possible to determine the IP address of a container without any EXPOSEd ports.

I also threw in a change to expose HostIP on the Address struct in addition to HostPort.

Fixes #79

Previously, it was not possible to determine the IP address of a container
without any EXPOSEd ports.
jwilder added a commit that referenced this pull request May 13, 2015
@jwilder jwilder merged commit c3d80b3 into nginx-proxy:master May 13, 2015
@jwilder
Copy link
Collaborator

jwilder commented May 13, 2015

Thanks @md5

@mjaverto
Copy link

Great, thanks @md5

@md5 md5 deleted the ip-without-exposed-ports branch May 13, 2015 13:20
@md5
Copy link
Contributor Author

md5 commented May 13, 2015

👍

@jwilder Once you cut a release, I think this PR combined with #83 will make it possible to fix nginx-proxy/nginx-proxy#115

@viranch
Copy link
Contributor

viranch commented Jul 4, 2015

This changes the Docker Gen Structure, can the wiki be updated? I'd contribute but I'm not familiar with review/pull requests for wikis.

@md5
Copy link
Contributor Author

md5 commented Jul 4, 2015

@viranch The wiki is freely editable by the community. It would be awesome if you could update it! 👍

@viranch
Copy link
Contributor

viranch commented Jul 4, 2015

@md5 How about putting it in the README.md itself instead of linking to the wiki? I can make a PR.

@md5
Copy link
Contributor Author

md5 commented Jul 4, 2015

You'd have to see what @jwilder thinks. Here's the last time the discussion came up, which resulted in the current documentation on the wiki: #25

@viranch
Copy link
Contributor

viranch commented Jul 11, 2015

@md5 Opened a pull request for doc update: #96 cc @jwilder do have a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: How to catch the IP of the container that has no exposed ports?
4 participants