-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Support Overlay Network #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
deb4050
a66115f
13bb99c
2eb9775
5c828cb
9341f54
658e20f
ebab7cf
163d1ce
2b41831
47631eb
b42cd85
74fb2ac
6b88365
88cc096
6928d62
f669345
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ load test_helpers | |
@test "[$TEST_FILE] separated containers (nginx + docker-gen + nginx.tmpl)" { | ||
docker_clean bats-nginx | ||
docker_clean bats-docker-gen | ||
|
||
# GIVEN a simple nginx container | ||
run docker run -d \ | ||
--label bats-type="nginx" \ | ||
|
@@ -73,6 +73,7 @@ load test_helpers | |
-v /var/run/docker.sock:/tmp/docker.sock:ro \ | ||
-v $BATS_TEST_DIRNAME/../nginx.tmpl:/etc/docker-gen/templates/nginx.tmpl:ro \ | ||
--volumes-from bats-nginx \ | ||
--expose 80 \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Forgive me if this is covered in the previous comments, but why is this change needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @md5 See this comment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
jwilder/docker-gen:0.7.0 \ | ||
-notify-sighup bats-nginx \ | ||
-watch \ | ||
|
@@ -91,7 +92,7 @@ load test_helpers | |
docker logs bats-docker-gen | ||
false | ||
} >&2 | ||
|
||
# THEN | ||
assert_nginxproxy_behaves bats-nginx | ||
} | ||
|
@@ -120,4 +121,3 @@ function assert_nginxproxy_behaves { | |
run curl_container $container /data --header "Host: webFOO.bats" --head | ||
assert_output -l 0 $'HTTP/1.1 503 Service Temporarily Unavailable\r' | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-gen
0.7.0 should have this field available now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwilder Thanks, I'm currently working to run the tests.
@md5 Yes of course, but it's a problem. The best use case stays to use docker-gen and nginx in the same container. Currently, the only test which fails is docker.bats (nginx + docker-gen + nginx.tmpl). I works on and I'm come back make a checkpoint.