Run logrotate only logrotate config changes

[clwluvw]

Proposed changes

Use notify handler to run logrotate if logrotate config changes.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING document
• I have added Molecule tests that prove my fix is effective or that my feature works
• I have checked that all Molecule tests pass after adding my changes
• I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

[alessfg]

There're some issues with the Travis Docker service atm. Not entirely sure if it's on their end or whether some package broke (I can't reproduce the issue myself so I'm going to go with the former).I'll rerun the tests when the issue gets fixed.

[clwluvw]

@alessfg Can this be removed with this PR?
https://github.com/nginxinc/ansible-role-nginx/blob/master/tasks/main.yml#L70

[alessfg]

Hm I would rather leave it there since the debug output tasks can also fail if NGINX isn't running already (which happens to be the case in some distros where the service doesn't get started upon installation of NGINX). Is there any particular reason why you'd like to see it removed?

[clwluvw]

@alessfg Not really just a warning that can be ignored I think

[WARNING]: flush_handlers task does not support when conditional

[alessfg]

Yep. That warning doesn't apply in this case.

[clwluvw]

According to #298 (comment) if this repo is going to deprecate, is there any reason there is no logrotate config in your mentioned repo?

[alessfg]

This repo won't deprecate. It's going to continue being used to install and setup NGINX, while NGINX config related tasks while move to another repo.

[clwluvw]

This repo won't deprecate. It's going to continue being used to install and setup NGINX, while NGINX config related tasks while move to another repo.

@alessfg So this repo is just used for installing and the repo you mentioned is used to configure an installed nginx?
If yes can you please explain more why?

[alessfg]

Check #306 for a brief explanation as to why.

[clwluvw]

@alessfg Makes sense, thanks. So could you please check the CI why it fails again? 😃

[alessfg]

I cancelled the build to make #306 go faster. I'll rerun it once I merge that PR.