Fix NGINX Plus license removal option #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enablerepo parameter in the NGINX Plus install task is not needed and causes some issues when rerunning that task as part of the NGINX Plus license removal process.
alessfg
changed the title
alessfg
added
bug
aknot242
approved these changes
Nov 4, 2020
| @@ -1,15 +1,16 @@ | |||
| --- | |||
| - name: (Alpine Linux) Configure NGINX Plus repository | |||
| - name: (Alpine Linux) {{ nginx_license_status is defined | ternary('Remove', 'Configure') }} NGINX Plus repository | |||
There was a problem hiding this comment.
wow, this works? Totally thought you had to wrap the whole string in "" if jinja filters are used.
There was a problem hiding this comment.
Yep. I'll leave this here for reference https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#when-to-quote-variables-a-yaml-gotcha
|
I should note that there's no proper Molecule tests in place to test the license removal option since it's not idempotent as of today. Making the option idempotent is on the roadmap but there's no ETA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
nginx_pluslicense fails on CentOS #336.Checklist
Before creating a PR, run through this checklist and mark each as complete.
defaults/main/*.yml,README.mdandCHANGELOG.md)