Skip to content

Change NGINX config check handler directory #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Mar 22, 2021

Proposed changes

Change the command directory when running the NGINX configuration check handler to prevent edge case errors when the handler is run from a directory that the NGINX process' user does not have access to.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that all Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

Change directory when running the NGINX configuration check handler to prevent edge errors related to NGINX permissions
@alessfg alessfg self-assigned this Mar 22, 2021
@alessfg alessfg added the bug Something isn't working label Mar 22, 2021
@alessfg alessfg added this to the 0.19.2 milestone Mar 22, 2021
@alessfg alessfg merged commit a982bce into main Mar 22, 2021
@alessfg alessfg deleted the change-config-check-handler-directory branch March 22, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant