Skip to content

Feat: Ansible backwards compatibility #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Feat: Ansible backwards compatibility #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eab5847
Omit module parameter if unavailable in the current version
fidanf Dec 28, 2021
f3b00e4
Omit module parameter for older core versions
fidanf Dec 28, 2021
8f5e55b
Merge branch 'main' into feat-ansible-base-compatibility
fidanf Feb 8, 2022
f1eb361
Add FEATURES block for 0.23.0
fidanf Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ BREAKING CHANGES:

CentOS 8 has reached EoL and has thus been removed from the list of supported platforms.

FEATURES:

Support for ansible-base (ansible-core `<2.12`).

BUG FIXES:

The Molecule `upgrade` scenario verification test no longer has to be updated on each new NGINX OSS release.
Expand Down
2 changes: 1 addition & 1 deletion tasks/opensource/install-debian.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
name: "nginx{{ nginx_version | default('') }}"
state: "{{ nginx_state }}"
update_cache: true
allow_downgrade: true
allow_downgrade: "{{ omit if ansible_version.full is version('2.12', '<') else true }}"
ignore_errors: "{{ ansible_check_mode }}"
notify: (Handler) Run NGINX
4 changes: 2 additions & 2 deletions tasks/opensource/install-redhat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
enabled: true
gpgcheck: true
mode: 0644
module_hotfixes: true
module_hotfixes: "{{ omit if ansible_version.full is version('2.11', '<') else true }}"
state: "{{ (nginx_state == 'uninstall') | ternary('absent', 'present') }}"
when: nginx_manage_repo | bool

Expand All @@ -17,6 +17,6 @@
name: "nginx{{ nginx_version | default('') }}"
state: "{{ nginx_state }}"
update_cache: true
allow_downgrade: true
allow_downgrade: "{{ omit if ansible_version.full is version('2.12', '<') else true }}"
ignore_errors: "{{ ansible_check_mode }}"
notify: (Handler) Run NGINX
2 changes: 1 addition & 1 deletion tasks/plus/install-debian.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
name: "nginx-plus{{ nginx_version | default('') }}"
state: "{{ nginx_state }}"
update_cache: true
allow_downgrade: true
allow_downgrade: "{{ omit if ansible_version.full is version('2.12', '<') else true }}"
ignore_errors: "{{ ansible_check_mode }}"
when: nginx_license_status is not defined
notify: (Handler) Run NGINX
2 changes: 1 addition & 1 deletion tasks/plus/install-redhat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
name: "nginx-plus{{ nginx_version | default('') }}"
state: "{{ nginx_state }}"
update_cache: true
allow_downgrade: true
allow_downgrade: "{{ omit if ansible_version.full is version('2.12', '<') else true }}"
ignore_errors: "{{ ansible_check_mode }}"
when: nginx_license_status is not defined
notify: (Handler) Run NGINX