Skip to content

Add s390x as a platform for Molecule tests #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 27, 2023
Merged

Add s390x as a platform for Molecule tests #580

merged 14 commits into from
Jan 27, 2023

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Jan 26, 2023

Proposed changes

BUG FIXES:

Remove the arch option from the Debian family NGINX repository source. In its current form this prevented the role from working any platforms beyond x86_64/amd64 and aarch64/arm64.

TESTS:

Explicitly test some distributions using aarch64 and s390x as the Molecule platform. This should ensure the role works as intended across the various architectures that are officially supported.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jan 26, 2023
@alessfg alessfg added bug Something isn't working tests Improvements to tests labels Jan 26, 2023
@alessfg alessfg added this to the 0.23.3 milestone Jan 26, 2023
@alessfg alessfg merged commit b1b7f92 into main Jan 27, 2023
@alessfg alessfg deleted the test-s390x branch January 27, 2023 13:03
@alessfg alessfg changed the title Add s390x as a platform for Molecule tests Add s390x as a platform for Molecule tests Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improvements to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant