-
Notifications
You must be signed in to change notification settings - Fork 89
Nginx plus dashboard additions #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx plus dashboard additions #155
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
For the The changes made in #120 will be merged when we merge our feature branch to main in the NGF repo. |
I have hereby read the F5 CLA and agree to its terms |
ngf team wasn't added as reviewers to this for some reason |
- type: IPAddress | ||
value: 127.0.0.3 | ||
- type: IPAddress | ||
value: 25.0.0.3 | ||
- type: CIDR | ||
value: 27.0.0.1/32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we're actually using these addresses, I think we're limited to the addresses in RFC 5737, "IPv4 Address Blocks Reserved for Documentation"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, didn't know this was a thing, made the change
Created #160 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerns addressed
Proposed changes
Problem: The Nginx Plus dashboard document needs to be updated with information on configuring access to it.
Solution: Add a section in
dashboard.md
giving a brief overview on how to change access to the dashboard with an example and a link to the data plane configuration document for more information. Additionally updated theapi.md
document to reflect the current state for NGF on main.Testing: Checked the rendered documentation.
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
)Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.
Please refer to our style guide for guidance about placeholder content.