Skip to content

Update docs for regex matching for HTTPRoutes and GRPCRoutes #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users need updated documentation for regex matching header and query params for HTTPRoutes and GRPCRoutes

Solution: Adds documentation for advanced routing and gateway compatibility document.

Testing: Deploy preview

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

NGF Repository Story - nginx/nginx-gateway-fabric#1965

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@salonichf5 salonichf5 requested a review from a team as a code owner February 10, 2025 17:55
Copy link

github-actions bot commented Feb 10, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@sjberman
Copy link
Contributor

This should not be targeting main, this should target ngf-release-2.0. Main is for docs we want to be published right now.

@bjee19 bjee19 requested a review from a team February 10, 2025 18:46
@salonichf5 salonichf5 changed the base branch from main to ngf-release-2.0 February 10, 2025 18:53
@salonichf5
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@salonichf5 salonichf5 merged commit 145c74f into nginx:ngf-release-2.0 Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants