Skip to content

feature: define Staged Configs #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 21, 2025
Merged

feature: define Staged Configs #264

merged 14 commits into from
Mar 21, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Mar 6, 2025

Proposed changes

Based on internal issue 1638. Checklist of what to cover (mostly in intros)

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@JTorreG JTorreG added the product/nginx-one NGINX One Console label Mar 11, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 11, 2025
@mjang mjang force-pushed the feature-staged-configs-release-1 branch from fde8cf9 to f74f3ec Compare March 12, 2025 14:17
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/264/

@mjang mjang force-pushed the feature-staged-configs-release-1 branch from cffbc19 to 3b94942 Compare March 12, 2025 21:03
@mjang mjang self-assigned this Mar 13, 2025
@mjang mjang force-pushed the feature-staged-configs-release-1 branch from 13a0ce8 to f738007 Compare March 13, 2025 16:32
@mjang mjang requested a review from jasonclopper March 13, 2025 16:36
@mjang mjang marked this pull request as ready for review March 13, 2025 16:36
@mjang mjang requested review from a team as code owners March 13, 2025 16:36
@JTorreG
Copy link
Contributor

JTorreG commented Mar 13, 2025

seeing some inconsistencies on how "instance(s)'' is capitalized

@mjang mjang marked this pull request as draft March 14, 2025 19:57
@mjang mjang marked this pull request as ready for review March 21, 2025 15:35
@mjang
Copy link
Contributor Author

mjang commented Mar 21, 2025

Will merge (after final approval) and after https://gitlab.com/f5/nginx/one/saas/control-plane/-/merge_requests/2840 is merged.

I'm assuming @vrmare 's approval based on the comments.

@mjang
Copy link
Contributor Author

mjang commented Mar 21, 2025

Merging based on (internal) Slack acceptance from @jasonclopper and @vrmare

@mjang mjang merged commit 63bcadd into main Mar 21, 2025
9 checks passed
@mjang mjang deleted the feature-staged-configs-release-1 branch March 21, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants