generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 89
feature: define Staged Configs #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JTorreG
reviewed
Mar 11, 2025
content/nginx-one/how-to/nginx-configs/view-edit-nginx-configurations.md
Outdated
Show resolved
Hide resolved
JTorreG
reviewed
Mar 11, 2025
JTorreG
reviewed
Mar 11, 2025
JTorreG
reviewed
Mar 11, 2025
10 tasks
fde8cf9
to
f74f3ec
Compare
✅ Deploy Preview will be available once build job completes!
|
cffbc19
to
3b94942
Compare
13a0ce8
to
f738007
Compare
JTorreG
reviewed
Mar 13, 2025
JTorreG
reviewed
Mar 13, 2025
JTorreG
reviewed
Mar 13, 2025
JTorreG
reviewed
Mar 13, 2025
JTorreG
reviewed
Mar 13, 2025
seeing some inconsistencies on how "instance(s)'' is capitalized |
mjang
commented
Mar 14, 2025
Co-authored-by: Jon Torre <[email protected]>
mjang
commented
Mar 14, 2025
content/nginx-one/how-to/nginx-configs/view-edit-nginx-configurations.md
Outdated
Show resolved
Hide resolved
mjang
commented
Mar 14, 2025
mjang
commented
Mar 14, 2025
mjang
commented
Mar 14, 2025
JTorreG
reviewed
Mar 17, 2025
Will merge (after final approval) and after https://gitlab.com/f5/nginx/one/saas/control-plane/-/merge_requests/2840 is merged. I'm assuming @vrmare 's approval based on the comments. |
mjang
commented
Mar 21, 2025
mjang
commented
Mar 21, 2025
content/nginx-one/how-to/nginx-configs/view-edit-nginx-configurations.md
Outdated
Show resolved
Hide resolved
mjang
commented
Mar 21, 2025
Merging based on (internal) Slack acceptance from @jasonclopper and @vrmare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Based on internal issue 1638. Checklist of what to cover (mostly in intros)
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩