Skip to content

Update NGINXaaS documentation for native-metrics integration #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

arpith-f5
Copy link
Contributor

@arpith-f5 arpith-f5 commented Mar 17, 2025

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Documentation change for NGINXaaS to add info about native-metrics integration

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

Copy link

github-actions bot commented Mar 17, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginxaas NGINX as a Service for Azure labels Mar 17, 2025
Copy link
Contributor

@russokj russokj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only problem is I can't approve - @jputrino
(maybe because it's still in draft mode)

@JTorreG
Copy link
Contributor

JTorreG commented Mar 24, 2025

@arpith-f5 please move it out of draft when it is ready for review

@arpith-f5
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@arpith-f5 arpith-f5 force-pushed the native-metrics branch 2 times, most recently from 7b696ab to 6f125bb Compare May 20, 2025 19:16
@arpith-f5 arpith-f5 marked this pull request as ready for review May 20, 2025 19:17
@arpith-f5 arpith-f5 requested review from a team as code owners May 20, 2025 19:17
@arpith-f5 arpith-f5 merged commit 47c7177 into nginx:main May 20, 2025
6 checks passed
@arpith-f5 arpith-f5 deleted the native-metrics branch May 20, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginxaas NGINX as a Service for Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants