Skip to content

fix: Clarify README-type files from the community PoV #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Dec 31, 2024

Proposed changes

Update instructions from the contributor PoV.

  • Update F5 instructions
  • Include instructions for linking to a GH issue in the PR template

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

* Update F5 instructions
* Include instructions for linking to a GH issue in the PR template
@mjang mjang requested a review from a team as a code owner December 31, 2024 16:11
@mjang mjang self-assigned this Dec 31, 2024
@mjang mjang merged commit bb82176 into main Dec 31, 2024
3 of 5 checks passed
@mjang mjang deleted the december-31-review branch December 31, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants