Skip to content

feat: NGINX One Console. Deploy certs/keys on CSGs, part one #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Dec 31, 2024

Proposed changes

This is the public release of documentation related to how you can deploy certificates on Config Sync Groups.

Note: we had multiple approvals internally, so that meets our requirement for 2 or more approvals for significant new/revised content.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mjang mjang self-assigned this Dec 31, 2024
@mjang mjang marked this pull request as ready for review January 2, 2025 17:24
@mjang mjang requested review from a team as code owners January 2, 2025 17:24
@mjang
Copy link
Contributor Author

mjang commented Jan 2, 2025

Two approvals previously given internally. Merging as is.

@mjang mjang merged commit 0d70d68 into main Jan 2, 2025
4 of 5 checks passed
@mjang mjang deleted the feat-csg-approved branch January 24, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant