Skip to content

Minor fixes to NGINX Plus Installation Guide. #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Minor fixes to NGINX Plus Installation Guide. #381

merged 2 commits into from
Apr 11, 2025

Conversation

y82
Copy link
Contributor

@y82 y82 commented Apr 9, 2025

Proposed changes

This patch adds minor but useful fixes to the Install guide:

  • the crt and key filenames are "nginx-repo", so they should be renamed after downloading similar to license.jwt
  • if the repo file is modified, the repo update command (sudo apt update) needs to be done
  • path to the nginx.conf file now specified for the 'License management' step
  • 2 latest supported versions updated to R34 and R33

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@y82 y82 requested a review from a team as a code owner April 9, 2025 10:42
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) labels Apr 9, 2025
@y82 y82 enabled auto-merge (squash) April 9, 2025 11:58
@y82 y82 self-assigned this Apr 9, 2025
@y82 y82 disabled auto-merge April 11, 2025 20:47
@y82 y82 merged commit c65408e into nginx:main Apr 11, 2025
6 checks passed
@y82 y82 deleted the install branch April 11, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant