-
Notifications
You must be signed in to change notification settings - Fork 89
PR from Jay #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR from Jay #512
Conversation
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms 2 out of 3 committers have signed the CLA. |
I have hereby read the F5 CLA and agree to its terms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'd love to hear your feedback to my comments. Thanks so much for your contribution!
content/nginx/admin-guide/security-controls/securing-http-traffic-upstream.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/securing-http-traffic-upstream.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/securing-http-traffic-upstream.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/securing-http-traffic-upstream.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jaypolansky1 for your contribution, and congratulations!
All contributors have signed, despite the failing test. |
* docs: add support for lightweight mode and clarify ClickHouse configuration * build(deps): bump github/codeql-action from 3.28.15 to 3.28.16 (#459) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.15 to 3.28.16. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@45775bd...28deaed) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Mike Jang <[email protected]> * fix: Address typo, update metadata for Add a Staged Configuration topic (#549) This commit fixes a typo in the main body text of the documentation, and also updates the Hugo frontmatter to new parameter names and values. * Updated example description for uwsgi and Django. (#552) Co-authored-by: Alan Dooley <[email protected]> * Fixed URL to dynamic modules for Wildfly deployment guide. (#548) * Fixed URL to dynamic modules for Wildfly deployment guide. * Apply suggestions from code review Co-authored-by: Alan Dooley <[email protected]> --------- Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Alan Dooley <[email protected]> * Removed random symbols introduced in #512 (#546) * Add a new trigger to build push workflow (#554) feat: Add a new trigger to build push workflow * added flag to use to skip installing clickhouse * updated install guides with latest script changes * edits to system config titles * added NGINX Agent version requirement for lightweight NIM * added step for adding NGINX signing key for manual install * updated clickhouse version variable * added variable for lightweight NIM NGINX Agent requirement * reworded lightweight option to lightweight mode * added steps for adding instances * added steps for setting up metrics reporting * edits * added lightweight mode content to docker compose doc * Apply suggestions from code review Co-authored-by: Jon Torre <[email protected]> * edits to helm deploy for lightweight mode * Update license_usage_offline.sh * feat: Updated nim install-script (#202) * Update install-nim-bundle.sh * fix: Update install-nim-bundle.sh * removed cruft from docker-compose-lightweight.yaml * edits to docker compose comments * Update license_usage_offline.sh * feat: Updated nim install-script (#202) * Update install-nim-bundle.sh * fix: Update install-nim-bundle.sh * feat: Update the value of ssl_protocols. (#672) * NGF: Update release version to v2.0.1 (#671) Update doc version for NGF release 2.0.1 * NGF: replace static-mode with controller (#669) Problem: The static-mode command has been renamed. Solution: Update to `controller`. * Fix missing quote (#676) A quotation was missing that was not caught by the original PR pipeline. * updates to helm config settings with new chart name * docs: add 2.20 RNs * Update install-nim-manual.md * Update install.md * docs: add 2.20 KIs * incremented helm chart version table * nim 2.20 ki update steps * Update install-nim-bundle.sh (#208) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Mike Jang <[email protected]> Co-authored-by: yar <[email protected]> Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Lam <[email protected]> Co-authored-by: Jon Torre <[email protected]> Co-authored-by: Chetan Jain <[email protected]> Co-authored-by: salonichf5 <[email protected]> Co-authored-by: Saylor Berman <[email protected]> Co-authored-by: Jon Cahill-Torre <[email protected]> Co-authored-by: Micheal Kingston <[email protected]>
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Give a brief overview of the problem or feature being addressed.
Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩