Skip to content

PR from Jay #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025
Merged

PR from Jay #512

merged 6 commits into from
May 6, 2025

Conversation

jaypolansky1
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@jaypolansky1 jaypolansky1 requested a review from a team as a code owner May 4, 2025 21:19
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) labels May 4, 2025
Copy link

github-actions bot commented May 4, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


2 out of 3 committers have signed the CLA.
✅ (jaypolansky1)[https://github.com/jaypolansky1]
✅ (mjang)[https://github.com/mjang]
❌ @“jaypolansky1”
“jaypolansky1” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@jaypolansky1
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms.

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'd love to hear your feedback to my comments. Thanks so much for your contribution!

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jaypolansky1 for your contribution, and congratulations!

@mjang mjang added the community label May 6, 2025
@mjang
Copy link
Contributor

mjang commented May 6, 2025

All contributors have signed, despite the failing test.

@mjang mjang merged commit 7133d2f into nginx:main May 6, 2025
1 of 2 checks passed
y82 added a commit to y82/documentation that referenced this pull request May 13, 2025
@y82 y82 mentioned this pull request May 13, 2025
10 tasks
y82 added a commit that referenced this pull request May 14, 2025
travisamartin added a commit that referenced this pull request Jun 16, 2025
* docs: add support for lightweight mode and clarify ClickHouse configuration

* build(deps): bump github/codeql-action from 3.28.15 to 3.28.16 (#459)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.15 to 3.28.16.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@45775bd...28deaed)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.28.16
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Mike Jang <[email protected]>

* fix: Address typo, update metadata for Add a Staged Configuration topic (#549)

This commit fixes a typo in the main body text of the documentation, and
also updates the Hugo frontmatter to new parameter names and values.

* Updated example description for uwsgi and Django. (#552)

Co-authored-by: Alan Dooley <[email protected]>

* Fixed URL to dynamic modules for Wildfly deployment guide. (#548)

* Fixed URL to dynamic modules for Wildfly deployment guide.

* Apply suggestions from code review

Co-authored-by: Alan Dooley <[email protected]>

---------

Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>

* Removed random symbols introduced in #512 (#546)

* Add a new trigger to build push workflow (#554)

feat: Add a new trigger to build push workflow

* added flag to use to skip installing clickhouse

* updated install guides with latest script changes

* edits to system config titles

* added NGINX Agent version requirement for lightweight NIM

* added step for adding NGINX signing key for manual install

* updated clickhouse version variable

* added variable for lightweight NIM NGINX Agent requirement

* reworded lightweight option to lightweight mode

* added steps for adding instances

* added steps for setting up metrics reporting

* edits

* added lightweight mode content to docker compose doc

* Apply suggestions from code review

Co-authored-by: Jon Torre <[email protected]>

* edits to helm deploy for lightweight mode

* Update license_usage_offline.sh

* feat: Updated nim install-script (#202)

* Update install-nim-bundle.sh

* fix: Update install-nim-bundle.sh

* removed cruft from docker-compose-lightweight.yaml

* edits to docker compose comments

* Update license_usage_offline.sh

* feat: Updated nim install-script (#202)

* Update install-nim-bundle.sh

* fix: Update install-nim-bundle.sh

* feat: Update the value of ssl_protocols. (#672)

* NGF: Update release version to v2.0.1 (#671)

Update doc version for NGF release 2.0.1

* NGF: replace static-mode with controller (#669)

Problem: The static-mode command has been renamed.

Solution: Update to `controller`.

* Fix missing quote (#676)

A quotation was missing that was not caught by the original PR pipeline.

* updates to helm config settings with new chart name

* docs: add 2.20 RNs

* Update install-nim-manual.md

* Update install.md

* docs: add 2.20 KIs

* incremented helm chart version table

* nim 2.20 ki update steps

* Update install-nim-bundle.sh (#208)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Mike Jang <[email protected]>
Co-authored-by: yar <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Lam <[email protected]>
Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: Chetan Jain <[email protected]>
Co-authored-by: salonichf5 <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Jon Cahill-Torre <[email protected]>
Co-authored-by: Micheal Kingston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants