fix: unmanaged certs only include metadata #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview will be available once build job completes!
|
mjang
commented
May 27, 2025
mjang
commented
May 27, 2025
content/nginx-one/how-to/config-sync-groups/manage-config-sync-groups.md
Outdated
Show resolved
Hide resolved
y82
approved these changes
May 28, 2025
sylwang
approved these changes
May 28, 2025
content/nginx-one/how-to/config-sync-groups/manage-config-sync-groups.md
Outdated
Show resolved
Hide resolved
sylwang
reviewed
May 28, 2025
| @@ -37,7 +37,7 @@ Config Sync Groups support configuration inheritance and persistance. If you've | |||
|
|
|||
| On the other hand, if you remove all instances from a Config Sync Group, the original configuration persists. In other words, the group retains the configuration from that first instance (or the original configuration). Any new instance that you add later still inherits that configuration. | |||
|
|
|||
| {{< tip >}}You can use _unmanaged_ certificates. Your actions can affect the [Config Sync Group status](#config-sync-group-status). For future instances on the data plane, if it: | |||
| {{< tip >}}You can use _unmanaged_ certificates. NGINX One Console does not store unmanaged certs or keys, only metadata associated with the certs or keys for monitoring. Your actions can affect the [Config Sync Group status](#config-sync-group-status). For future instances on the data plane, if it: | |||
There was a problem hiding this comment.
This should also be changed to be the same as above:
only metadata associated with certs for monitoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Based on feeback.
We need to clarify: N1C collects only the metadata associated with unmanaged certs. IOW, it does not include the actual cert.
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.mdandCHANGELOG.mdFootnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩