-
Notifications
You must be signed in to change notification settings - Fork 123
Add extra containers entry to inject side cars into deployment #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @ab-andresc! Welcome to the project! 🎉 Thanks for opening this pull request! Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. |
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
20fcf9f
to
2040ee0
Compare
I have hereby read the F5 CLA and agree to its terms |
e1b1ab5
to
66936a3
Compare
Hi @ab-andresc, I'm curious about the use cases you mention. What benefit does the sigsci-agent or JWT validation do for the control plane? What connections are these sidecars handling? |
Per offline conversation, it seems the intention is to actually configure containers for the NGINX deployment, not the NGF control plane deployment. Since the control plane now provisions the NGINX data plane, the latter is no longer exposed directly in the helm chart. Instead, we include these configurable fields in the NginxProxy CRD and then the control plane uses that to set the deployment config when provisioning. An example of how we add a new field for this type of use case can be seen here: #3319. |
@@ -410,6 +416,11 @@ type DaemonSetSpec struct { | |||
// | |||
// +optional | |||
Container ContainerSpec `json:"container"` | |||
// ExtraContainers defines additional containers to be added to the NGINX Pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// ExtraContainers defines additional containers to be added to the NGINX Pod. | |
// ExtraContainers defines additional containers to be added to the NGINX Pod. |
// ExtraContainers defines additional containers to be added to the NGINX Pod. | ||
// Uses upstream corev1.Container to allow arbitrary sidecars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great if you could specify one example of the sidecars
users can use.
Proposed changes
This feature adds an extra variable to the deployment template to add extra containers.
Problem: Users would like to inject additional sidecars, these can do a variety of things.
Example: Install sigsci agent as a sidecar
https://www.fastly.com/documentation/guides/next-gen-waf/setup-and-configuration/kubernetes/kubernetes-agent-module/
Use case 2:
Do JWT validation with a separate container
Solution: Adds an entry to the template.
Testing: Manually added a sidecar, rendering looks correct.
Before creating a PR, run through this checklist and mark each as complete.