feat: Add helm values for cert-generator job pod placement #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Deploying the new version 2.0.0 chart we see the Job/foo-cert-generator pod stuck on pending scheduling when all cluster nodes have taints.
Solution: Add the ability to inject job.spec.template.spec.{affinity,nodeSelector,tolerations,topologySpreadConstraints} to alter pod placement. If you prefer to only add a subset of these, like only tolerations was needed in my case, please do inform and I can adjust.
github-actions
bot
added
documentation
sjberman
approved these changes
Jun 11, 2025
bjee19
approved these changes
Jun 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.0 #3494 +/- ##
============================================
Coverage 86.74% 86.74%
============================================
Files 127 127
Lines 15079 15079
Branches 62 62
============================================
Hits 13081 13081
Misses 1845 1845
Partials 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick commit for release 2.0.1