-
Notifications
You must be signed in to change notification settings - Fork 123
Add WAFPolicy CRD #3496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add WAFPolicy CRD #3496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: As a user of NGF with an NGINX One subscription I want a method to configure WAF protection on my Gateways and Routes So that I can enable the NAP WAF feature for the applications that need it. Solution: Define the WafPolicy CRD.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/nap-waf #3496 +/- ##
===============================================
Coverage ? 86.94%
===============================================
Files ? 127
Lines ? 15308
Branches ? 62
===============================================
Hits ? 13309
Misses ? 1846
Partials ? 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ciarams87
approved these changes
Jun 11, 2025
sindhushiv
approved these changes
Jun 11, 2025
salonichf5
approved these changes
Jun 12, 2025
bjee19
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: As a user of NGF with an NGINX One subscription, I want a method to configure WAF protection on my Gateways and Routes, So that I can enable the NAP WAF feature for the applications that need it.
Solution: Define the WAFPolicy CRD.
Testing: Verified that I can create a sample policy and validation works properly.
Closes #3449
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.