-
Notifications
You must be signed in to change notification settings - Fork 123
Fix index out of bounds error when building status #3513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well. Solution: Adjust the logic to ensure we don't access indices that are out of bounds.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3513 +/- ##
==========================================
- Coverage 86.79% 86.78% -0.02%
==========================================
Files 127 127
Lines 15079 15079
Branches 62 62
==========================================
- Hits 13088 13086 -2
- Misses 1840 1841 +1
- Partials 151 152 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjee19
approved these changes
Jun 13, 2025
salonichf5
approved these changes
Jun 13, 2025
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well. Solution: Adjust the logic to ensure we don't access indices that are out of bounds. Add Nginx Gateway HPA(nginx#3447)
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well. Solution: Adjust the logic to ensure we don't access indices that are out of bounds. ADD Nginx Gateway HPA(nginx#3447)
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well. Solution: Adjust the logic to ensure we don't access indices that are out of bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well.
Solution: Adjust the logic to ensure we don't access indices that are out of bounds.
Testing: Verified that this error does not occur in the previous scenario.
Closes #3512
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.