Skip to content

Prepare for action publishing - update readme and use the ARM template from the specified commit #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2022
Merged

Prepare for action publishing - update readme and use the ARM template from the specified commit #16

merged 2 commits into from
May 27, 2022

Conversation

bangbingsyb
Copy link
Contributor

@bangbingsyb bangbingsyb commented May 26, 2022 •
edited
Loading

This change is for preparing the action for its initial publishing to GitHub action marketplace, and it includes:

  1. Readme update to provide details on how the action handles file paths: readme preview
  2. Update the deployment script to download the config ARM template from a specified commit instead of from the latest commit. This can prevent breaking change to the published action if we need to change the ARM template in the future.

Related items:

#10
https://github.com/nginxinc/nalb-shared/issues/217

@bangbingsyb bangbingsyb requested review from ornj and amudukutore May 26, 2022 21:13
ornj
ornj approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@ornj ornj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💨

@bangbingsyb bangbingsyb merged commit 514937e into main May 27, 2022
@bangbingsyb bangbingsyb deleted the bangbingsyb/update-readme branch September 7, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ornj ornj ornj approved these changes

@amudukutore amudukutore Awaiting requested review from amudukutore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bangbingsyb @ornj