Grid: Center justify text content #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Playwright visual snapshot differences were detected.View the Playwright report |
|
/approve-snapshots |
Updating snapshots. Click here to see the status. |
Please download the artifacts here and commit your updated screenshots. |
nginx-jack
force-pushed
the
centre-justify-content-grid
branch
from
f362d0b to
4af59e8
Compare
|
This messes up the breadcrumb alignment. I think it'll look better if the crumbs follow the content. |
nginx-jack
force-pushed
the
centre-justify-content-grid
branch
from
4af59e8 to
5a2954a
Compare
❌ Playwright visual snapshot differences were detected.View the Playwright report |
nginx-jack
force-pushed
the
centre-justify-content-grid
branch
2 times, most recently
from
a21d084 to
7925672
Compare
❌ Playwright visual snapshot differences were detected.View the Playwright report |
nginx-jack
force-pushed
the
centre-justify-content-grid
branch
from
7925672 to
3af99ff
Compare
❌ Playwright visual snapshot differences were detected.View the Playwright report |
Move breadcrumb into same element as text content to allow it to follow the content on larger screens. Slightly increase gutter gap on larger screens.
nginx-jack
force-pushed
the
centre-justify-content-grid
branch
from
3af99ff to
54a837c
Compare
danielledeleo
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Center justify text content. This matches responsive behaviour similar to stripe docs.
Screen.Recording.2025-04-15.at.11.38.39.mov