-
Notifications
You must be signed in to change notification settings - Fork 3
Add hashtag to headings #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Playwright visual snapshot differences were detected.View the Playwright report |
7402ba0
to
7adc4b0
Compare
7adc4b0
to
d343eb5
Compare
Need suggestions on if the text and not just the If so, the |
@lamATnginx I think we'd want it to be clickable for sure - might need to |
Need a design pass but here is the updated video Screen.Recording.2025-04-22.at.8.37.10.AM.mov |
Heading color has been changed to black + removed hover underline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM locally, nice one Lam!
Proposed changes
Closes https://github.com/nginxinc/docs-platform/issues/433
Video to demonstrate hovering shows
#
within its bounds + there is a#
on the current anchor link:https://github.com/user-attachments/assets/9f155f24-da60-40f1-b86d-eb5d5609c849
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)